Skip to content

Add shapes tests #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2016
Merged

Add shapes tests #389

merged 1 commit into from
Apr 2, 2016
+53 −0

Conversation

n-riesco
Copy link
Contributor

@n-riesco n-riesco commented Apr 2, 2016

From #378 (comment)

  • add a shapes_test.js file in test/jasmine/tests/
  • add a suite using the shapes.json mock.
  • assert the shape nodes in the right place after Plotly.relayout

Sorry, something went wrong.

@etpinard
Copy link
Contributor

etpinard commented Apr 2, 2016

Nicely done.

@etpinard etpinard merged commit fee3de6 into plotly:master Apr 2, 2016
@n-riesco n-riesco deleted the shapes-test branch April 6, 2016 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n-riesco @etpinard